Repository navigation
feat(metrics): expose opt-in Lance object-store diagnostics - #421
Merged
Merged
Conversation
36 of 43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Application phase timings currently combine Lance file encoding and storage I/O. Add an opt-in
lance-io-metricsfeature to core and server so Lance 13's storage counters, request durations and retryable-response metrics use the existing recorder and/metricsendpoint. Defaults remain unchanged; the server registers metric descriptions after installing its recorder.The documentation explains label cardinality and the limits of overlapping request durations. A real Lance write, merge, close and reopen test verifies retained data and emitted read/write metrics; CI runs the optional feature explicitly. Histogram regression checks enforce separate finite label domains for application and Lance metrics, including under the all-features coverage configuration.
Core builds without default features again: the backlog-refusal counter now uses the existing optional metrics shim, and disabled flush metrics avoid computing unused labels. CI checks this configuration as well.
Validation: actual Lance I/O integration test, all-features histogram regression, optional-feature Clippy, core without default features, full repository CI helper, and workspace package checks.
Refs #378