Repository navigation
fix: reject legacy compaction on owned and draining rollout tables - #420
Merged
Merged
Conversation
beinan
force-pushed
the
codex/guard-owned-worker-compaction
branch
from
October 20, 2026 23:14
9b11285 to
2e95586
Compare
beinan
marked this pull request as ready for review
October 20, 2026 23:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The worker rollout compaction endpoint currently accepts untracked base-table rewrites even when the table is draining or configured for owned maintenance. That bypass can race the master’s fenced recovery and handoff.
Apply the existing legacy admission check before opening the table or acquiring its write lock. Owned/draining tables use the master’s fenced maintenance path. The regression test holds a live reader while checking immediate rejection for both protected states, and exercises successful compaction for an ordinary legacy table.
Validation: formatting and diff checks passed. The first Clippy run found unused response values in the regression test; the final commit now checks the create status and compaction result explicitly. Rebased onto main after #418 merged. The focused local regression passed on the initial functional patch (1 passed, 0 failed); response assertions were tightened afterward. Final-head CI must pass before merge.
This closes an HTTP compaction bypass; automatic hotspot enrollment and durable legacy worker admission remain separate unfinished work.