Repository navigation
Fence master maintenance on tables still using legacy worker merges - #419
Merged
Merged
Conversation
added 4 commits
October 20, 2026 23:10
beinan
force-pushed
the
codex/all-master-maintenance-fences
branch
from
October 20, 2026 23:10
487f72e to
e780119
Compare
beinan
marked this pull request as ready for review
October 20, 2026 23:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Masters currently bypass execution fencing for compact/index/repair on tables outside
MERGE_OWNED_TARGETS. A stuck operation on a newly hot legacy table can therefore retain an untracked write even though the native recovery machinery exists.Add an opt-in
MASTER_FENCE_LEGACY_MAINTENANCE=truemode that uses the existing durable admission, real-progress watchdog, commit permits and storage recovery barrier for new rollout/generic master maintenance executions. Prepared compaction/index work keeps its separate preparation phase. The execution scope also observes successful file IO so long scans need not finish an entire phase to demonstrate progress. Recovery scans continue resolving recorded protocol-2 maintenance executions after flag rollback.This does not change worker merge admission, enroll legacy tables into native merging, fence pre-upgrade writes, change datagen behavior, add Pods, or stop ingestion. It is the master-write prerequisite for safe automatic handoff, not a claim that handoff is complete. The flag defaults off for a measured canary rollout.
Validation: all 13 maintenance execution tests passed against isolated local etcd 3.7.0, including successful real file reads across multiple idle windows, all three stalled legacy maintenance kinds, version fencing before successor execution, flag rollback with an unresolved barrier, and preserved retry budgets. The source hashes matched the tested commit at completion. Rebased onto main after #418 merged; final-head CI is running.