Repository navigation
feat(wal): persist publication outcomes from selected manifests - #414
Merged
Merged
Conversation
50 of 56 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Record a durable Published outcome only when the catalog's selected immutable manifest matches the exact pending plan and prepared descriptors. Identical retries recover the original confirmation index across takeover; stale owners cannot create a new outcome.
Retain source selections, descriptors and pins until a separate source closure protocol. Share selected manifest records through Arc and validate outcomes in bounded v7 checkpoints. This change does not retire payloads or enable production ingestion.
Extend real Lance six-process tests with a lost confirmation reply, catalog snapshot, full process restart and quorum outcome recovery before verifying the actual transaction and complete payloads.
Refs #378.
Testing
The complete repository CI helper passed: 605 workspace Rust tests, Python 229 passed / 2 skipped / 1 expected failure, formatting, Clippy, Ruff and Pyright. All-feature WAL Clippy, server build and workspace packaging also passed.
All 95 focused Rust tests passed, including 10 process tests. Immutable source hashes matched before and after qualification.
The qualified change was rebased onto current main without changing any PR source files. Additional inherited main changes are covered by their merged PR checks; final-head CI validates the combined tree.