Repository navigation
feat(wal): select immutable manifests through the catalog quorum - #412
Merged
Merged
Conversation
40 of 47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Select immutable staged Lance manifests through the replicated catalog instead of treating an epoch check before a blob write as a publication fence. Each managed dataset incarnation has a durable current head and bounded version records. Reservations bind the exact transaction, prepared descriptors, owner and predecessor; retries recover the selected identity and never replace an occupied target.
Add bounded quorum manifest lookups and v6 checkpoint recovery. Source pins, publication plans, descriptors and manifests remain retained; outcome advancement and coordinated collection are separate work. Bootstrap requires exclusive managed ownership and verification of the actual starting manifest.
Real Lance tests use six persistent TCP WAL processes, unique manifest files and strict catalog lookups. They verify full payloads after snapshot/restart, lost commit replies, and an old owner paused after upload and resumed after takeover. The test transport adapter does not enable the production ingestion service or GC.
Refs #378.
Testing
Passed 92 focused Rust tests (including 10 process tests), 605 workspace Rust tests, and 229 Python tests (2 skipped, 1 expected failure). Completed the full repository CI helper, all-feature WAL Clippy, server build, workspace packaging and immutable source verification.