Repository navigation
feat(wal): persist immutable prepared Lance descriptors - #410
Merged
Merged
Conversation
40 of 47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Persist one immutable set of materialized Lance fragment descriptors for each pending publication plan. Exact retries return the original preparation index, changed bytes are rejected, and publisher takeover or snapshot recovery retains the chosen files and fixed transaction.
Descriptors use bounded shared bytes with a format identifier and SHA-256 digest; WAL replicas do not deserialize Lance fragments or Arrow bodies. The optional application/checkpoint format advances to v5. Recording descriptors neither proves source pins nor authorizes external commits or source retirement.
Add real Lance integration tests that write Arrow data through source WAL processes, materialize immutable files, restart all six catalog/source processes, recover the recorded descriptors, and verify exact payloads and transaction identity. An occupied target must not rebase the recovered plan.
Refs #378.
Testing
The complete repository CI helper passed for this source increment: 605 workspace Rust tests, Python 229 passed / 2 skipped / 1 expected failure, formatting, Clippy, Ruff and Pyright. All-feature WAL Clippy, server build and workspace packaging also passed.
All 86 focused Rust tests passed, including the real Lance process tests. The seven process tests also passed ten consecutive repetitions. Immutable source hashes matched before and after qualification.
The final branch also includes the independently qualified publication-GC regressions from #408. The qualified increment is unchanged after rebasing; final-head CI validates the combined branch.