Repository navigation
feat(wal): persist received Raft snapshots atomically - #403
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A lagging replica can receive a Raft snapshot that replaces its uncommitted tail. Add
GroupLog::install_snapshotto persist the accepted snapshot, optional Ready suffix, HardState and application binding in one synced engine batch, without changing sibling groups or node identity. Invalid or stale transitions are rejected; an uncertain engine write fences every group sharing the engine.This is the storage boundary only. Callers must first validate and durably stage the application snapshot and retain its dependencies across uncertain outcomes. Application snapshot files, transfer and Node integration follow separately; this PR does not enable production ingestion or physical reclamation.
Refs #378.
Testing