Repository navigation
fix: measure WAL component disk footprint from files - #397
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
context-wal-lab diskreported raft-engine's segment-size estimate asdisk_bytes. Batches can overshoot the target segment size, so that estimate can understate the actual WAL footprint.Measure the closed engine's regular files outside write/reopen timing, report apparent and allocated sizes, and retain the engine estimate separately.
disk_bytesnow sums each file's larger apparent/allocated size. These fields measure directory footprint, not physical bytes written or write amplification.Refs #378.
Testing