Repository navigation
fix: preserve completed read snapshots during WAL merges - #396
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuous WAL merges can make a completed listing retry all its decoding merely because a newer base version was committed. After three such attempts, the request fails despite having read a complete snapshot. Separately, missing WAL data can surface as
Wrapped error: Not found, which the case-sensitive missing-file check fails to recognize, causing HTTP 500 instead of refreshing the read view.Validate the base version around WAL manifest capture, before payload reads. This still rejects a base/WAL pair split by a merge and retries missing generations, but accepts a successfully read captured snapshot even if another commit follows it. Recognize wrapped missing-file messages regardless of capitalization. Pinned reads, pending-generation caps, and the bounded retry count are retained; missing generations never produce partial results.
Evidence and validation:
7255…, two HTTP 404s in 32 reads onfe08…. A repeat onfe08…captured a missing_mem_wal/.../data/*.lancefile wrapped asNot found. These tests do not establish that every production slow read has this cause.dataset changed during read; retry the request: each successful snapshot read was followed by a later write/merge before returning.