Repository navigation
feat: add bounded vectored WAL frame writes - #393
Merged
Merged
Conversation
40 of 47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #378
Summary
WAL framing can write the length, header and each shared payload with separate socket calls. Add an opt-in
vectored-iohelper that sends the same bytes using at most 64 borrowedIoSlicedescriptors, without concatenating payloads. Short writes, scalar fallback, errors and cancellation preserve exact body-byte accounting; prepared exchanges can send bodies separately after a grant.This is a transport building block for the ingestion work tracked in #378. It does not enable distributed ingestion in the production writer or claim a throughput improvement. Incomplete exchanges still require discarding the connection, and socket acceptance is not a durability ACK.
Testing
cargo test -p lance-context-wal --features vectored-io --liband feature-enabled Clippy with--all-targets -- -D warningspassed.