Repository navigation
feat: identify slow reads in bounded recovery signals - #392
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production recorded
/recordsreads taking 217–241 seconds before returning 404. The recovery endpoint retained only 5xx outcomes, while route-level latency histograms could not identify the affected table.Retain the latest completed read taking at least five seconds in the existing bounded per-table hint cache, including its status and response-header duration. These additive schema-1 fields preserve the nonblocking recording path, five-minute expiry, 4,096-entry cap and 1 MiB response limit. Failures and slow reads precede ordinary activity when the response is truncated. Request parameters, record IDs and payloads are excluded. This supplies diagnostic hints; it does not cancel requests or infer that a slow read needs a merge.
Validation: metrics unit tests passed (10, plus one ignored manual benchmark); enabled/disabled HTTP integration tests passed, including a delayed 404, in-flight demand and payload exclusion. Tests also cover threshold boundaries, independent expiry, preservation after successful requests, lock contention and bounded truncation.
cargo clippy -p lance-context-metrics --all-targets -- -D warnings, formatting and diff checks passed. This is independent of #390 and does not block its release.