Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disconnected rollout reads can retain accepted handlers while recovery of a retired instance's acknowledged WAL currently requires a new append. This change cancels the read phase when the HTTP caller leaves (after protected store opening), and adds an explicit one-shot
--replay-own-walcommand that replays, seals, drains, and closes an existing table before starting any HTTP listener or sweeper.The replay command requires an explicit instance identity and propagates fencing, drain, and close failures. Operators must establish ownership and retire the previous owner before using it; the CLI does not implement that retirement protocol.
Validation: 14 drain and 33 rollout tests passed for read cancellation; the crash/replay test recovered the exact 20 acknowledged rows without a post-restart append and verified idempotent replay; 3 replay CLI and 4 config tests passed. The crash test uses local storage. Same-image Azure recovery qualification and production retirement verification remain outstanding.