Repository navigation
fix: prevent racing dataset creation from overwriting data - #385
Merged
beinan merged 2 commits intoOct 19, 2026
Merged
Conversation
42 of 49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lance checks whether a dataset exists before creating it, then reopens its URI when committing. If another writer creates the dataset and appends between these checks, the delayed creator's initial overwrite can erase that append. Restrict
StorageBase::create_with_optionsto publishing version 1 and reject a successor manifest before committing it.The restriction is scoped to the creation future, so the returned dataset remains usable for ordinary appends. This protection lives in lance-context and requires no Lance OSS change.
Refs #378.
Testing