Repository navigation
fix: honor registered rollout dataset locations - #383
Merged
Merged
Conversation
39 of 46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A rollout registry entry can point to a dataset outside the path derived from its logical name. A cold worker currently opens that derived path, the metadata endpoint reports it, and uncached deletion targets it. Use the registered URI for open/delete and the opened store's URI in metadata responses. Recheck the directory entry before caching a new handle, and refuse deletion when an existing handle points to a different URI.
This is a prerequisite for separately assigned physical table locations. It does not add generation allocation, distributed cache invalidation, or a catalog compare-and-delete protocol.
Refs #378.
Testing