Skip to content

fix: honor registered rollout dataset locations - #383

Merged
beinan merged 1 commit into
lance-format:mainfrom
beinan:codex/rollout-registry-uri
Oct 19, 2026
Merged

beinan merged 1 commit into
lance-format:mainfrom
beinan:codex/rollout-registry-uri

Conversation

@beinan

@beinan beinan commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

A rollout registry entry can point to a dataset outside the path derived from its logical name. A cold worker currently opens that derived path, the metadata endpoint reports it, and uncached deletion targets it. Use the registered URI for open/delete and the opened store's URI in metadata responses. Recheck the directory entry before caching a new handle, and refuse deletion when an existing handle points to a different URI.

This is a prerequisite for separately assigned physical table locations. It does not add generation allocation, distributed cache invalidation, or a catalog compare-and-delete protocol.

Refs #378.

Testing

  • Real local Lance datasets verify registered-location selection, metadata, uncached deletion and preservation of a dataset at the derived path.
  • Controlled registry changes during a real dataset open verify removal/replacement cannot install that stale handle.
  • A live-handle mismatch rejects deletion without removing either dataset or its catalog entry.
  • Full repository check script passed: workspace formatting, Clippy and all-target Rust tests (591 passed); Python tests (229 passed, 2 skipped, 1 xfailed), Ruff formatting/lint and Pyright.

@beinan
beinan merged commit 1199b14 into lance-format:main Oct 19, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant