Repository navigation
perf: move owned rollout upload buffers into core records - #382
Merged
Merged
Conversation
45 of 52 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Large JSON and multipart rollout uploads already own their decoded buffers, but the HTTP handler cloned the complete blob and token arrays when converting requests into core records. Consume those requests through
From<AddRolloutRequest>so the core records retain the existing allocations. Keep the borrowed conversion API and all field/default handling compatible.This removes one conversion copy on the current ingestion path. Arrow encoding and request decoding still have their own allocation costs.
Refs #378.
Testing