Repository navigation
feat: reserve configurable WAL maintenance headroom - #379
Merged
Merged
Conversation
Refs lance-format#378. Use synthetic placement fixtures for public compatibility tests.
43 of 51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The default proposal control window may be too small for full-copy checkpoints and log rewrites. Add
Budget::limit_dataso callers can lower the node-wide producer ceiling while retaining the total maintenance budget and charging every outstanding reservation. Zero and upward limit changes are rejected.Keep public compatibility tests portable by using synthetic node addresses and a fixed, independently checked layout fingerprint. The admission module remains opt-in and does not yet change production ingestion or bound already accepted replication traffic.
Refs #378.
Testing