Repository navigation
feat: add stable WAL session placement and receipt scopes - #376
Merged
Merged
Conversation
37 of 45 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the optional
placementmodule to the independent WAL crate. It routes a tenant/table/session key to a stable virtual bucket, validates an immutable RF3 layout, and scopes receipts by cluster, layout fingerprint, group and log index. Invalid or ambiguous ownership is rejected before routing; changing a validated layout requires migration.The hash formats match the existing Rust experiments. This PR supplies placement types only; it does not connect a distributed writer to production ingestion.
Testing
.codex/skills/ci-pr-helper/scripts/run_ci_checks.sh: workspace Rust formatting, Clippy and tests; Python 229 passed, 2 skipped, 1 xfailed; Ruff and Pyright passed.cargo test --release -p lance-context-wal --features placement: three tests, including the recorded layout compatibility fixture and an independently checked session hash vector.cargo clippy --release -p lance-context-wal --features lab,placement --all-targets -- -D warnings.Refs #378.