Repository navigation
chore: upgrade Lance dependencies to 13.0.0 - #374
Merged
Merged
Conversation
beinan
marked this pull request as ready for review
October 19, 2026 02:45
beinan
added a commit
that referenced
this pull request
Oct 19, 2026
## Summary Add a feature-gated, unpublished Rust WAL experiment crate to compare Arrow IPC decoding/row-copy costs and local durable log writes before integrating the distributed WAL. The codec benchmark verifies complete Arrow equality and actual payload buffer sharing, including unaligned input; the raft-engine benchmark performs synced writes across groups, reopens storage, and compares every payload. Results are JSON with allocation counts and separate write/recovery/verification timing. The README documents measurement limits, and CI builds/lints the optional binary and runs tiny correctness smoke cases. ## Testing - Passed the repository's full `run_ci_checks.sh`: workspace format, all-target Clippy and tests; Python pytest (229 passed, 2 skipped, 1 expected failure), Ruff format/lint, and Pyright (0 errors/warnings). - Component check and all-target Clippy with `--features lab` passed. Codec smoke passed all five paths and shared-buffer checks; disk smoke reopened and verified 64 entries. - Spelling and diff checks passed. Rebasing after #374's squash merge preserved the exact source tree tested locally.
40 of 47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade Rust Lance and optional Python pylance dependencies from 9 to 13.0.0, including the SSTable metadata, explicit manifest refresh, SealFence, and object-store API adaptations. Preserve exact-version merge authorization across Lance's internal commit retries; a regression test races a concurrent manifest commit with authorization revocation.
Before deploying to existing MemWAL datasets, flush and merge all old pending generations using the old binaries, then upgrade readers and writers together. The upstream field-ID change prevents safely mixing old flushed generations with new readers; see
docs/design/lance-13-upgrade.md.Testing
run_ci_checks.sh: workspace format, all-target Clippy and tests; Python pytest (229 passed, 2 skipped, 1 expected failure), Ruff format/lint, and Pyright (0 errors/warnings).lance-context-serverand the Python extension against the upgraded dependencies.Refs #378.