Repository navigation
feat(rollout): expose flush-on-add in SDKs - #346
Open
KaiqiJinWow wants to merge 2 commits into
Open
KaiqiJinWow wants to merge 2 commits into
KaiqiJinWow wants to merge 2 commits into
Conversation
Contributor
Author
|
Hi @beinan , could you take a look when you have a chance? CI is green. Thanks! |
KaiqiJinWow
force-pushed
the
feat/rollout-client-flush
branch
from
October 22, 2026 23:22
9f32b9e to
f4a9edc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #191.
Problem
The server already supports
POST /rollouts/{name}/records?flush=true, but the Rust and Python clients cannot request it. The standalone remoteflush()call is a no-op, so SDK callers that need read-your-write visibility must poll for the background sweeper.Change
add_with_flushandadd_rollouts_with_flushmethods.flush=Falseto sync and async Pythonaddandadd_one.?flush=trueon the same append request.A flush can also publish earlier or concurrent pending appends. If the flush step fails, the append may already be durable, so retryable callers should supply and reuse stable record ids. Remote flush-on-add requires server v0.6.5 or newer.
Testing
cargo check --locked -p lance-context-client -p lance-context -p lance-context-python --all-featurescargo clippy --locked -p lance-context-client -p lance-context -p lance-context-python --all-features -- -D warningscargo test --locked -p lance-context --all-featurescargo test --locked -p lance-context-server flush_true_gives_read_your_write_and_default_does_not