Repository navigation
fix: bind persistent native publisher admission to Pod UID - #319
Merged
Merged
Conversation
beinan
marked this pull request as ready for review
October 6, 2026 02:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A persistent native publisher could reuse an operator record meant for a previous Pod with the same name. Track the operational supervisor in
deploy/catchupand require its downward-API Pod UID to match the authorized UID before each attempt, while retaining the full-operator CAS, persistent owner, backoff and child-join behavior.The standalone deployment example requires one container and
restartPolicy: Never. This does not enable production recreation or change the native Rust Job controller.Validation: seven real-etcd/process regressions pass, including stale same-name UID rejection, a concurrent operator change, subsequent admissions, retained backoff and SIGTERM joining its child. Ruff and diff checks pass. Isolated Kubernetes validation passed with the actual downward API and native binary: a same-name replacement rejected the predecessor UID without changing attempt/failure records, then three incarnations merged 48/32/16 generations and verified all 160 full payloads with pending 0 and no OOM. Accepted-create response loss and a controller crash after accepted creation both reconciled the same Pod; exact terminal UID/CID evidence preceded removal. The changed supervisor has not been deployed to production.