Repository navigation
fix: drain stalled HTTP responses without cancelling accepted writes - #318
Merged
Merged
Conversation
beinan
marked this pull request as ready for review
October 6, 2026 02:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A worker can spend its entire termination grace period waiting for HTTP clients that stopped receiving responses, leaving its WAL merge endpoint unavailable during a rollout. Graceful shutdown now closes admission, joins accepted handlers (even after client disconnect), then retires only response sockets whose writes have stopped making progress. Resident writers close afterward.
HTTP_SHUTDOWN_RESPONSE_IDLE_SECSdefaults to 120. Successful socket writes reset the interval; there is no new total merge/query/download deadline. Exact-socket control descriptors avoid descriptor-reuse races, at the cost of one additional descriptor per connection. Response bodies remain cancellable; staged append streams only prepare unreachable immutable files and do not publish manifests.Validation: