Repository navigation
fix: honor short maintenance cooldown after recovery - #315
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovery of an interrupted native publisher can create its first durable failure record after the supervisor has checked admission. The fresh two-second cooldown previously made
run_asreject the same pass immediately, which the supervisor counted as another failed execution and extended into a four-minute delay.Wait for up to two seconds of durable cooldown before reserving a new maintenance execution, then reread the failure record before starting payload work. Longer delays still return the existing retry error. The change does not clear failure budgets, bypass storage fencing, or start an additional execution attempt.
Validation: real-etcd regressions cover recovery materializing a new catch-up deadline, continuation only after that deadline, rejection of an extended deadline, and preservation of long failure budgets. All 142 master tests passed against real etcd; master Clippy (
--all-targets -- -D warnings), formatting, andgit diff --checkpassed. Longer newly materialized deadlines still use the existing deferred error; this narrow fix addresses the observed two-second recovery cooldown.