Repository navigation
feat: trace records with ordered turns and batch ID lookup - #304
Merged
Merged
Conversation
beinan
marked this pull request as ready for review
October 4, 2026 18:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a built-in
TraceRecordschema for one conversation turn per row:session_id, orderedturn_id, stable rowid, role, content, and optional source/metadata. Separate row identity preserves content variants at the same turn position.TraceStorewraps the existing local/remote GenericStore API, reusing its indexed base/WAL batch reads and ID-only deduplication probes (up to 1,024 IDs). This creates one dataset and requires no new dependencies, registries, or HTTP routes. Document retry/visibility semantics and the fact that lookup plus append is not atomic insert-if-absent.Validation: 21 API tests, 3 real-Lance integration tests, and an actual HTTP/Rust-client round trip pass locally. Coverage includes late turns, variants, replay, merge/reopen, null content/metadata, 1,024-ID batch bounds, deferred visibility, and rejection of invalid batches before writes. Formatting and all-target Clippy for API/core/server pass locally; all 10 GitHub checks pass on
44910a1, including Rust/HA tests, coverage, Clippy, Python tests and three-platform wheel builds.