Repository navigation
test(core): cover WAL merge after concurrent index creation - #291
Merged
beinan merged 1 commit intoOct 3, 2026
Merged
Conversation
beinan
marked this pull request as ready for review
October 1, 2026 14:05
beinan
changed the title
beinan
force-pushed
the
codex/refresh-base-before-generic-merge
branch
from
October 3, 2026 05:27
987cf78 to
3bee038
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long-lived
GenericStorecan retain an unindexed base manifest after another handle creates an ID index. A subsequent WAL merge must observe that index and apply updates without aCreateIndexconflict or duplicate rows.Add a regression that opens two shard handles, creates the index through the first, and commits a prepared WAL update through the stale second handle. It checks that the WAL drains and exactly one updated row remains.
This PR changes tests only. Current main already refreshes the base unconditionally in
StorageBase::commit_merge; the earlier production change in this PR is redundant and has been removed. Rebased ontoed26433.Validation:
cargo fmt --all -- --check: passed.git diff --check: passed.CARGO_TARGET_DIR=/tmp/lc/target cargo test -p lance-context-core --lib -j 2 generic_store::tests:: -- --test-threads=2: 16 passed, including the new regression.3bee038: Rust workspace and etcd HA tests, coverage, Clippy, formatting, spelling, Python lint/tests, and Linux x86_64/ARM64 plus macOS ARM64 wheel builds.