Repository navigation
fix: validate Rust registry metadata before publishing - #255
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.6.7 Rust release failed when crates.io rejected
lance-context-metrics 0.1.0withmissing or empty metadata fields: description. Add the missing description and validate the required registry metadata for every publishable workspace crate before packaging or publishing. The check ignorespublish = falsecrates and runs on manifest changes as well as workflow changes.cargo package --no-verifyonly warns about missing metadata, so the existing PR validation did not catch this upload failure. The new check fails before any crate is uploaded.Validation:
cargo package --workspace --exclude lance-context-python --allow-dirty --no-verify --all-features --lockedpasses.cargo publish -p lance-context-metrics --dry-run --allow-dirty --lockedpasses, including compilation of the packaged crate.git diff --checkpass.After merging, retry Rust publishing with
workflow_dispatchonmainandmode=release. Re-running the failed tag-based run would still use the old manifest.Failed release: https://github.com/lance-format/lance-context/actions/runs/35279364852