Repository navigation
Preserve the workspace lockfile in Python source distributions - #254
Merged
beinan merged 1 commit intoSep 17, 2026
Merged
Conversation
Remove the obsolete nested Cargo.lock that makes maturin omit the root workspace lock. Check the packaged lock before uploading artifacts and cover packaging inputs in the publishing PR trigger. Keep the existing build commands compatible with workspace pruning in sdist builds. Generated with MAI Agents: https://github.com/infinity-microsoft/mai-agents Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a563b220-9ce6-4724-97e4-601ec8ffd89a
beinan
marked this pull request as ready for review
September 17, 2026 19:38
beinan
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the dependency-resolution failure in the x86_64 sdist build of #253 (failed run), independently of its wheel-size fix.
python/Cargo.lock. Python is a member of the root workspace, but Maturin 1.15 prefers the nested lock when packaging. The resulting sdist containspython/Cargo.lockand no root lock, so Cargo resolves fresh dependencies from the extracted workspace.--lockedis not a solution for the combined--sdistbuild: Maturin removes unused workspace members, requiring Cargo to prune their lock entries.The failed build selected
aws-smithy-types 1.7.0withaws-smithy-json 0.63.0and failed with E0308/E0004. The repaired sdist retains the checked-in1.4.9/0.62.7versions. No dependency upgrades or runtime-code changes; most deleted lines are the unused generated lockfile.Validation
maturin build --sdist --strip --offline(debug profile). Imported that wheel and exercised Datagen append, item/root history and folded codec metadata.git diff --checkpassed. No pre-commit configuration/hook is installed in this checkout.Linux release builds still need CI verification. This complements rather than replaces #253's stripping/size gate. No publishing was triggered, and the already-published v0.6.6 macOS artifact must not be replaced by the locally rebuilt wheel.
🤖 Generated with MAI Agents