Repository navigation
refactor(python): rename RemoteRolloutStore to AsyncRolloutStore - #129
Merged
Merged
Conversation
The class name described the wrong axis. `RemoteRolloutStore` wraps the exact
same `_RolloutStore` as the sync `RolloutStore` — its only distinguishing
feature is that it runs blocking calls in an executor so they can be awaited.
"Remote" is also misleading because the sync `RolloutStore.connect()` already
talks to a remote server; the async wrapper adds no remote-only behavior.
`AsyncRolloutStore` names the real distinction (async vs sync) and aligns with
the existing `AsyncContext` convention ("Async* = the async wrapper of a sync
class"). Clean rename with no deprecated alias: the class shipped in 0.6.1 and
has no callers beyond the remote test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the Python
RemoteRolloutStoreclass toAsyncRolloutStore. The oldname described the wrong axis:
RemoteRolloutStorewraps the same_RolloutStoreas the syncRolloutStore— its only distinguishing feature is running blocking calls inan executor so they can be
awaited.RolloutStore.connect()already talks to aremote server. The async wrapper adds no remote-only behavior.
AsyncRolloutStorenames the real distinction (async vs sync) and matches theexisting
AsyncContextconvention (Async* = the async wrapper of a sync class).Clean rename, no deprecated alias: the class first shipped in 0.6.1 and has
no callers beyond the remote test.
Changes
api.py: class rename + docstring +__repr__+ return-type strings +__all____init__.py: re-export +__all__test_rollout_remote.py: import + usages + docstringTest plan
pytest tests/test_rollout.py tests/test_rollout_remote.py→ 8 passed (remote test drives a reallance-context-serversubprocess through the renamed class)ruff checkclean on all changed filesgrep RemoteRolloutStore→ no remaining references