feat(netbox): add image bundling netbox-opennms-plugin - #96
Merged
Conversation
Add a new `netbox/` image project that layers our netbox-opennms-plugin onto the official NetBox image, following the repo's project contract (Dockerfile.tpl + version-lock.sh + release.tag + one-line Makefile) so CI discovers and builds it automatically. - Base pinned to netboxcommunity/netbox:v4.6.4; published tag mirrors the NetBox version (netbox:4.6.4). - Plugin pinned to git tag v0.0.2 (no PyPI release yet) and installed into /opt/netbox/venv with the image's own uv. The NetBox runtime image ships no git, so a throwaway build stage adds git, installs the plugin, and the populated venv is copied into a clean final image (no git/apt shipped). - Plugin is bundled but NOT activated: PLUGINS/PLUGINS_CONFIG are supplied at deploy time, keeping the image reusable and secret-free (per netbox-chart issue #173 guidance). - Renovate customManagers track both the NetBox base tag and the plugin git tag. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Ronny Trommer <ronny@no42.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
netbox/image project that layers our netbox-opennms-plugin onto the officialnetboxcommunity/netboximage. Follows the repo's project contract (Dockerfile.tpl+version-lock.sh+release.tag+ one-lineMakefile), so CI discovers and builds it automatically — no workflow changes.Design (from OpenSpec
add-netbox-opennms-image)/opt/netbox/venvbut not activated.PLUGINS/PLUGINS_CONFIG(incl. OpenNMS URL/credentials) are supplied at deploy time, keeping the image reusable and secret-free. This is the maintainer-recommended pattern from netbox-chart#173.netboxcommunity/netbox:v4.6.4; plugin git tagv0.0.2(no PyPI release yet). Published tag mirrors the NetBox version:netbox:4.6.4.git, so a throwaway build stage adds it, installs the plugin with the image's ownuv, and the populated venv is copied into a clean final image (nogit/aptin the published artifact).customManagerstrack the NetBox base tag and the plugin git tag.Verification (local)
import netbox_opennms→ OK, v0.0.2requests 2.34.2,lxml 6.1.1templates/(runtime-loaded), nostatic/→collectstaticnot neededlinux/amd64+linux/arm64build cleanlyshellcheck+hadolintpass on the new filesFollow-ups (not in this PR)
netboxrepository with Write for the CI robot is required before the firstmainpublish (else 401), same as the recent per-repo permission fixes.base_images.sh) base images (gobgp,retro-aim-server,robotframework,pleroma) could be generalized in a separate change.v0.0.2install upgrades none of NetBox's pinned deps.🤖 Generated with Claude Code