fix(dupligator): pin golang builder via base_images.sh so Renovate tracks it - #89
Merged
Merged
Conversation
…acks it dupligator/Dockerfile.tpl hardcoded `FROM "golang:1.18-alpine3.16"` with literal quotes around the image. Renovate's Dockerfile parser kept the quote, looked up the package `"golang` and got no result — the 'Package lookup failures' warning on the Dependency Dashboard (#83). Move the golang builder pin into base_images.sh, where the existing customManager already tracks docker pins, and reference it through a BUILDER_IMAGE variable like every other base image. The generated Dockerfile is byte-identical, so the build is unchanged. Closes the golang lookup failure reported in #83. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Ronny Trommer <ronny@no42.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dupligator/Dockerfile.tpl hardcoded
FROM "golang:1.18-alpine3.16"with literal quotes around the image. Renovate's Dockerfile parser kept
the quote, looked up the package
"golangand got no result — the'Package lookup failures' warning on the Dependency Dashboard (#83).
Move the golang builder pin into base_images.sh, where the existing
customManager already tracks docker pins, and reference it through a
BUILDER_IMAGE variable like every other base image. The generated
Dockerfile is byte-identical, so the build is unchanged.
Closes the golang lookup failure reported in #83.
Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Ronny Trommer ronny@no42.org