Repository navigation
feat: remember an approved phone and laptop across sessions - #47
Merged
Merged
Conversation
Bitrate-per-preset already shipped. The 15 fps Home toggle is Later (unscheduled), not v0.3. PR 9 is cancelled (user decision 2026-08-18).
Persist pairing_secret in trusted.json and on the phone so the next phonecam start can ApproveTrusted from Home Reconnect without a new QR. Secrets stay off the QR, GET /pairing, session.json, GET /trust, and start output. --no-trust skips the store for that process.
… laptop Do not rotate pairing_secret when Approve is a no-op. Attach the secret before the session flips approved so require-approval /status can deliver it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pairing_secreton laptop (~/.config/phonecam/trusted.json) and phone so the next session can tap Reconnect instead of scanning a QR.ApproveTrusted+POST /reconnectwithpairing_secret.phonecam trust list|revoke.--no-trustfor CI/demo.Why
v0.2 persistent trusted pairing. In-session reconnect (#46) still required a QR after
phonecam stop/ newstart.Testing
Evidence:
go test ./...+-race; AndroidtestDebugUnitTest(121 tests). Review closed two secret-rotation/delivery bugs.Privacy/Security Impact
Secrets never in QR,
GET /pairing,session.json, orGET /trust. Store is0700/0600./trustis loopback-only. Secret is as visible on the wire (once, over HTTP) as unencrypted RTP. Forget-on-phone is local only;phonecam trust revokebars the phone. No unused expiry (explicit revoke only). Protocolvstays 1.Notes
Draft. Does not add 15 fps, torch, USB, or mDNS. Please test: pair once,
phonecam stop&&start, tap Reconnect on the phone.