Skip to content

Add Tooling navbar dropdown linking to Gaffer - #968

Merged
George-Payne merged 1 commit into
masterfrom
george/ui-1595-tooling-dropdown-gaffer
Jun 4, 2026
Merged

George-Payne merged 1 commit into
masterfrom
george/ui-1595-tooling-dropdown-gaffer

Conversation

@George-Payne

@George-Payne George-Payne commented Jun 4, 2026 •

Copy link
Copy Markdown
Member

Adds a new Tooling dropdown to the docs navbar, between Clients & APIs and Developer Resources, with a single entry linking out to the Gaffer mini-site:

… · Clients & APIs · Tooling ▾ · Developer Resources
                      └─ Gaffer (Projections tooling) → https://gaffer.kurrent.io

The external link gets the theme's external-icon + new-tab behaviour automatically, matching the other outbound nav entries. The dropdown is intentionally a container for more currently-undocumented tools to be added later.

- Add a "Tooling" dropdown between Clients & APIs and Developer Resources
- One entry for now: Gaffer (Projections tooling) -> gaffer.kurrent.io

Surfaces the separate gaffer.kurrent.io site from the main docs nav.
The dropdown is a home for more undocumented tools later (UI-1595).
@George-Payne
George-Payne requested a review from a team as a code owner June 4, 2026 08:39
@linear-code

linear-code Bot commented Jun 4, 2026

Copy link
Copy Markdown

UI-1595

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

Docs Preview

  • Status: ⏳ Creating preview…

@qodo-code-review

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Add Tooling navbar dropdown linking to Gaffer

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Adds new Tooling dropdown to navbar between Clients & APIs and Developer Resources
• Links to Gaffer projections tooling at gaffer.kurrent.io
• Provides container for additional tools to be added later
Diagram
flowchart LR
  navbar["Navbar"] -- "adds Tooling dropdown" --> tooling["Tooling ▾"]
  tooling -- "contains link" --> gaffer["Gaffer Projections tooling"]
  gaffer -- "external link" --> gaffer_site["gaffer.kurrent.io"]

Loading

Grey Divider

File Changes

1. docs/.vuepress/configs/navbar.ts ✨ Enhancement +6/-0

Add Tooling dropdown with Gaffer link

• Adds new Tooling dropdown menu object with text "Tooling"
• Includes single child entry linking to Gaffer projections tooling
• Positioned between Clients & APIs and Developer Resources sections
• External link automatically inherits theme's external-icon and new-tab behavior

docs/.vuepress/configs/navbar.ts


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented Jun 4, 2026 •

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 🔗 Cross-repo conflicts (0)

Grey Divider


Advisory comments

1. Non-canonical Gaffer URL 🐞 Bug ⚙ Maintainability
Description
The new navbar link uses https://gaffer.kurrent.io (no trailing slash) while existing docs
consistently reference https://gaffer.kurrent.io/, creating inconsistent references and
potentially an extra redirect if the target site normalizes trailing slashes.
Code

docs/.vuepress/configs/navbar.ts[37]

+            {text: "Gaffer (Projections tooling)", link: "https://gaffer.kurrent.io"},
Evidence
The navbar adds Gaffer without a trailing slash, while an existing docs page links to the same site
using the trailing-slash form multiple times, showing an inconsistency introduced by this PR.

docs/.vuepress/configs/navbar.ts[34-39]
docs/getting-started/mcp.md[13-17]
docs/getting-started/mcp.md[115-123]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The navbar entry for Gaffer uses a non-canonical root URL (missing trailing slash) compared to other documentation references.

## Issue Context
Other docs pages already link to the Gaffer site using the trailing-slash form (`https://gaffer.kurrent.io/`). Keeping the navbar consistent reduces future churn (search/replace, audits) and avoids possible extra redirects.

## Fix Focus Areas
- docs/.vuepress/configs/navbar.ts[34-39]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

Docs build

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2b3fee2
Status: ✅  Deploy successful!
Preview URL: https://2e24e571.documentation-21k.pages.dev
Branch Preview URL: https://george-ui-1595-tooling-dropd.documentation-21k.pages.dev

View logs

@George-Payne
George-Payne merged commit 50d430e into master Jun 4, 2026
3 checks passed
@George-Payne
George-Payne deleted the george/ui-1595-tooling-dropdown-gaffer branch June 4, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants