fix(brief): require PR with green CI as no-mistakes terminal condition - #2667
Open
jgrizon wants to merge 15 commits into
Open
fix(brief): require PR with green CI as no-mistakes terminal condition#2667jgrizon wants to merge 15 commits into
jgrizon wants to merge 15 commits into
Conversation
…dapter agy runs crewmate and scout work only, on a Gemini quota pool separate from the Claude subscription, with Flash ids cheap enough for mechanical tasks. It is refused for a secondmate the same way muse is: its Stop hook is a plain notification with no blocking channel a primary's turn-end guard could hold a turn open with. Every fact recorded here was observed live against agy 1.1.15 on macOS arm64; docs/verification/runtime-backends.md carries the captures. Launch is `agy --dangerously-skip-permissions --add-dir <worktree> [--model] -i`. `--add-dir` is load-bearing rather than cosmetic: agy's hook payload carries workspacePaths, and that array is empty without it even from a git repo root, so the per-task guard could never match. The separate `--effort` flag is deliberately omitted because agy's own catalog encodes the level in the model id, and emitting both would allow a contradictory pair. Turn-end and busy state ride one firstmate-owned key in the shared global ~/.gemini/config/hooks.json, because agy's only project-scope hook surface needs a folder-trust grant firstmate will not write. bin/fm-agy-config.sh owns that edit surgically and refuses on a symlink, malformed JSON, or a non-object top level. The hook is inert for any session firstmate did not register: it fires only when a workspace in the payload holds a token pointer resolving to an entry in a private 0700 registry, and only when Stop reports fullyIdle. The registry entry, never the worktree pointer the agent can edit, carries the marker path and busy-event coordinates. The same installer declares the user-level skills root in skills.json, without which an agy crewmate cannot see no-mistakes at all - agy scans neither ~/.claude/skills nor ~/.agents/skills, and its documented "~/" entry form is accepted but not resolved in the global config. --dangerously-skip-permissions does not suppress agy's folder-trust dialog and there is no --trust flag, so the spawn accepts it in the pane, but only once the dialog's own text is on screen and only when the trusting option is the selected one. agy's composer is pi's separated shape with a `>` prompt glyph, so it reaches the existing identity-gated verdict rather than a new shape. Two narrow additions: the glyph strip is scoped to an agy identity, because applied to pi it would read a real line beginning "> " as an empty composer; and the scan now keeps the separator pair holding the cursor, because agy draws a second pair below its composer while a background task runs. Teardown's grok/kimi cleanup is generalized to one table and two helpers rather than a third copy, which also fixes the orca branch's missing fm-busy-state.js removal.
feat(harness): add the Antigravity CLI (agy) as a verified crewmate adapter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
no-mistakesdefinition of done inbin/fm-brief.shso crewmate worker briefs specify a PR with green CI as the only terminal condition, and explicitly state that a local commit, green local test suite, and completed pipeline step are all NOT done.Generated no-mistakes section
Before
After
Verification
bin/fm-lint.shpasses cleanly (ShellCheck 0.11.0, actionlint 1.7.12).tests/fm-brief.test.shpasses all 20 behavior checks including updated and new assertions for no-mistakes terminal conditions and false-finish exclusions.bash tests/fm-ask-user-authority.test.shpasses.