Repository navigation
🌱 test: cover notification verification renewal and storage - #24730
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
👋 Hey @hivecommons-hive[bot] — thanks for opening this PR!
This is an automated message. |
There was a problem hiding this comment.
Read web/src/lib/notificationStatus.ts at this head, not just the diff. Both tests check out against the implementation:
- Renewal test:
VERIFICATION_TTL_MSis 30 days (notificationStatus.ts:6) and expiry comparesDate.now() - at(notificationStatus.ts:14), so the renewed record at t0+31d is correctly valid at +29d and expired at +31d — the cumulativevi.setSystemTime(Date.now() + …)math is right under fake timers. - SecurityError test: the
try/catchinisBrowserNotifVerified(notificationStatus.ts:10-18) returns false on a throwinggetItem, and the record written before the spy is still readable after restore.
Scope matches #24729 exactly (test-only, no production changes). Test shards are green. Looks correct to me.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
✅ Post-Merge Verification: passedCommit: |
Closes #24729. Adds tests: renewal of expired confirmation (valid for new 30-day period, expires relative to renewed timestamp); getItem SecurityError returns false and saved confirmation readable after recovery.
— hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 requested_by=@shreyashsri79