Skip to content

🌱 test: cover notification verification renewal and storage - #24730

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-24729
Oct 31, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-24729

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #24729. Adds tests: renewal of expired confirmation (valid for new 30-day period, expires relative to renewed timestamp); getItem SecurityError returns false and saved confirmation readable after recovery.

— hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 requested_by=@shreyashsri79

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 31, 2026
@netlify

netlify Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 3d87238
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6ae594d99370fb3d8afa704d
😎 Deploy Preview https://deploy-preview-24730.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @hivecommons-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 31, 2026
@github-actions github-actions Bot added tier/1-lightweight ai-generated Pull request generated by AI labels Oct 31, 2026
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read web/src/lib/notificationStatus.ts at this head, not just the diff. Both tests check out against the implementation:

  • Renewal test: VERIFICATION_TTL_MS is 30 days (notificationStatus.ts:6) and expiry compares Date.now() - at (notificationStatus.ts:14), so the renewed record at t0+31d is correctly valid at +29d and expired at +31d — the cumulative vi.setSystemTime(Date.now() + …) math is right under fake timers.
  • SecurityError test: the try/catch in isBrowserNotifVerified (notificationStatus.ts:10-18) returns false on a throwing getItem, and the record written before the spy is still readable after restore.

Scope matches #24729 exactly (test-only, no production changes). Test shards are green. Looks correct to me.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 4b09f87 into main Oct 31, 2026
53 of 54 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-24729 branch October 31, 2026 07:33
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#247303d87238` sha256:13e533d9970a5106b832f5e1de606e2305bb2f88fcac8a79f85e384adcc0c264 — download from the dashboard or `hivectl review evidence #24730`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 4b09f876cfa8df5b0b441e9046af3dbffabf6cc1.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Post-Merge Verification: passed

Commit: 4b09f876cfa8df5b0b441e9046af3dbffabf6cc1
Specs run: smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/41181051918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tier/1-lightweight

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: cover notification verification renewal and storage read recovery

0 participants