Skip to content

🐛 fix(web): add keyboard navigation to dropdowns and tab bars #24708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hivecommons-hive merged 1 commit into from
Oct 30, 2026
Merged

🐛 fix(web): add keyboard navigation to dropdowns and tab bars #24708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions web/src/components/drilldown/views/ComplianceDrillDown.parts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export function ComplianceSummaryStats({
<div className="grid grid-cols-2 md:grid-cols-4 gap-3 mb-4">
<button
onClick={onClearFilter}
aria-pressed={!statusFilter}
className={cn(
cn('rounded-lg border p-3 text-left transition-colors', TOUCH_TARGET_HEIGHT_CLASS),
!statusFilter ? 'border-teal-500/40 bg-teal-500/10' : 'border-border bg-card/50 hover:border-border/80'
Expand All @@ -48,6 +49,7 @@ export function ComplianceSummaryStats({
</button>
<button
onClick={onPassClick}
aria-pressed={statusFilter === 'pass'}
className={cn(
cn('rounded-lg border p-3 text-left transition-colors', TOUCH_TARGET_HEIGHT_CLASS),
statusFilter === 'pass' ? 'border-green-500/40 bg-green-500/10' : 'border-border bg-card/50 hover:border-border/80'
Expand All @@ -58,6 +60,7 @@ export function ComplianceSummaryStats({
</button>
<button
onClick={onFailClick}
aria-pressed={statusFilter === 'fail'}
className={cn(
cn('rounded-lg border p-3 text-left transition-colors', TOUCH_TARGET_HEIGHT_CLASS),
statusFilter === 'fail' ? 'border-red-500/40 bg-red-500/10' : 'border-border bg-card/50 hover:border-border/80'
Expand All @@ -68,6 +71,7 @@ export function ComplianceSummaryStats({
</button>
<button
onClick={onOtherClick}
aria-pressed={statusFilter === 'other'}
className={cn(
cn('rounded-lg border p-3 text-left transition-colors', TOUCH_TARGET_HEIGHT_CLASS),
statusFilter === 'other' ? 'border-yellow-500/40 bg-yellow-500/10' : 'border-border bg-card/50 hover:border-border/80'
Expand Down
1 change: 1 addition & 0 deletions web/src/components/drilldown/views/ComplianceFooter.parts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ export function ComplianceClusterBreakdown({
<button
key={cluster}
onClick={() => onClusterClick(cluster)}
aria-pressed={clusterFilter === cluster}
className={cn(
'rounded-lg border p-2 text-left transition-colors',
TOUCH_TARGET_HEIGHT_CLASS,
Expand Down
1 change: 1 addition & 0 deletions web/src/components/layout/navbar/UpdateIndicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ export function UpdateIndicator({ showLabel = false }: UpdateIndicatorProps) {
}}
className={buttonClassName}
title={buttonTitle}
aria-label={buttonTitle}
>
{isUpgradeError ? (
<AlertTriangle className={ICON_SIZE} />
Expand Down
Loading