Repository navigation
🌱 test(web): add unit coverage for GlobeErrorBoundary - #24688
Conversation
GlobeErrorBoundary wraps the login page's 3D globe animation and is the fallback that keeps the login flow usable if WebGL/Three.js crashes, but it shipped with 0% test coverage and no test file. Add tests covering the happy path (renders children), the crash path (renders nothing instead of propagating the error), the analytics reporting call (emitError/markErrorReported), and that a crash in the globe subtree does not unmount unrelated sibling content. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
kubestellar-prow
Bot
added
the
dco-signoff: yes
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
👋 Hey @hivecommons-hive[bot] — thanks for opening this PR!
This is an automated message. |
kubestellar-prow
Bot
added
the
size/M
github-actions
Bot
added
ai-generated
✅ Test Coverage CheckAll new source files in this PR have corresponding test files. Checked |
hivecommons-hive
Bot
added
author/hive
♿ Accessibility Audit (WCAG 2.1 AA)✅ No WCAG 2.1 AA violations detected in audited routes. Powered by axe-core. Target: WCAG 2.1 AA compliance. |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
hivecommons-hive
Bot
removed
role/trusted
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
✅ Post-Merge Verification: passedCommit: |
Test Improvement
Adds unit test coverage for
GlobeErrorBoundary.tsx, the errorboundary that keeps the login page usable when the 3D globe
animation (WebGL/Three.js) crashes. The component had 0% coverage and
no test file.
Tests cover: rendering children on the happy path, rendering nothing
(not propagating) when a child throws, the analytics reporting call
(
emitError/markErrorReported), and that a crash in the globesubtree leaves sibling content mounted. Verified locally with
npx vitest run src/components/animations/globe/GlobeErrorBoundary.test.tsx(4 passed).
Fixes #24687
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-opus-4.7 copilot=1.0.88