Repository navigation
🐛 fix(web): add dark mode variants and design tokens to flagged components - #24686
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
👋 Hey @hivecommons-hive[bot] — thanks for opening this PR!
This is an automated message. |
kubestellar-prow
Bot
added
the
size/S
hivecommons-hive
Bot
added
author/hive
✅ Test Coverage CheckAll new source files in this PR have corresponding test files. Checked |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 |
♿ Accessibility Audit (WCAG 2.1 AA)✅ No WCAG 2.1 AA violations detected in audited routes. Powered by axe-core. Target: WCAG 2.1 AA compliance. |
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
Read the diff against the tree at ab884e3. This looks correct to me.
CHART_TOOLTIP_BG/CHART_TOOLTIP_BORDERexist atweb/src/lib/constants/ui.ts:105-106and resolve--chart-tooltip-bg/--chart-tooltip-borderwith dark fallbacks (#1a1a2e/#333, ui.ts:42-43) — the CSS-var-backed mechanism the PR body describes, and the same one already poweringCHART_TEXT_WHITE, which these three files import on the same line.- The swap matches the existing idiom:
web/src/components/acmm/TargetBalanceCharts.tsxalready usesbackgroundColor: CHART_TOOLTIP_BGfor its ECharts tooltip. - Pure constant substitution in all three files; formatters and the rest of the tooltip config are untouched.
One pre-existing nuance, not a defect of this PR: CHART_THEME values are resolved once at module load (ui.ts:35-38), so a live theme switch won't re-style ECharts tooltips until reload — identical behavior to the other CHART_THEME consumers.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
hivecommons-hive
Bot
removed
role/trusted
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
✅ Post-Merge Verification: passedCommit: |
Closes #24685, Closes #24684
llmd chart tooltips (LatencyBreakdown, ResourceUtilization, ThroughputComparison) used hardcoded rgba colors that drifted from the design system and ignored theme tokens. Now use CHART_TOOLTIP_BG/CHART_TOOLTIP_BORDER (CSS-var backed). Remaining findings are false positives: inline styles carry data-driven colors, '#NNNN' hits are issue-number comments, and widget export previews intentionally render a fixed palette.
— hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 requested_by=@clubanderson