Repository navigation
✨ feat(web): add health indicators to dashboard components - #24678
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
👋 Hey @hivecommons-hive[bot] — thanks for opening this PR!
This is an automated message. |
kubestellar-prow
Bot
added
the
size/XS
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Auto Test GeneratorThe following new files have no corresponding test file:
Please add tests or apply the |
✅ Test Coverage CheckAll new source files in this PR have corresponding test files. Checked |
hivecommons-hive
Bot
added
author/hive
♿ Accessibility Audit (WCAG 2.1 AA)✅ No WCAG 2.1 AA violations detected in audited routes. Powered by axe-core. Target: WCAG 2.1 AA compliance. |
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
Read the full tile and its caller, not just the diff. This looks correct to me.
web/src/components/cards/NetworkOverview.ServiceTypeTile.tsx:26—isClickable = count > 0already drives the cursor/role/tabIndex/title logic; the new dot reuses the same state, so it cannot disagree with the tile's existing behavior.ml-autoinside the existingflex items-centerrow (line 45) right-aligns it cleanly.- The
role="img"+aria-label("Status: active" / "Status: no services") means the state isn't conveyed by color alone; it's consistent with the existingtitletext at line 43. - Spot-checked the PR body's claim about the other Auto-QA-flagged files:
components/dashboard/CustomDashboard.tsxis indeed a re-export shim, andlib/unified/dashboard/components/DashboardEmptyState.tsxis a presentational empty state with no health data — so limiting the change to the service-type tile and closing #24677 is reasonable.
One honest caveat, not a defect: the dot indicates "has services vs. none", which is presence, not health in the degraded/healthy sense the Auto-QA heuristic suggests. Given this tile has no health data to draw on, that's the right scope. No test was added, but the change is purely presentational and reuses tested state; adding an assertion for the aria-label in an existing tile test would be a nice-to-have only.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
hivecommons-hive
Bot
added
stage/060-reviewed
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
hivecommons-hive
Bot
removed
role/trusted
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
✅ Post-Merge Verification: passedCommit: |
Auto-QA flagged dashboard components lacking health indicators. Adds a status dot (active / no services) with an accessible label to the network overview service type tile, so state is visible at a glance. Other flagged files are a re-export shim, a test file, and presentational pieces without health data.
Closes #24677
— hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 requested_by=@clubanderson