Repository navigation
🌱 test(web): add unit tests for untested components - #24665
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
dco-signoff: yes
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
👋 Hey @hivecommons-hive[bot] — thanks for opening this PR!
This is an automated message. |
kubestellar-prow
Bot
added
the
size/L
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 |
✅ Test Coverage CheckAll new source files in this PR have corresponding test files. Checked |
hivecommons-hive
Bot
added
author/hive
♿ Accessibility Audit (WCAG 2.1 AA)✅ No WCAG 2.1 AA violations detected in audited routes. Powered by axe-core. Target: WCAG 2.1 AA compliance. |
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
Read both components at head b84cd7a against the new tests; the tests describe real behavior, not assumed behavior:
BatchSummary.test.tsxmatchesBatchSummary.tsx: the progressbar'saria-valuenow/min/maxand the fill color logic (completed && failed === 0→--s-success,failed > 0→--s-warning, else--s-info) are exactly what the component renders, and the four breakdown items (✓ ✗ – ⊙) are each guarded by> 0as the zero/partial-count tests assert.ProviderSelector.test.tsxmatchesProviderSelector.tsx: button idstellar-provider-selector-btn,autolabel whensessionis null, unavailable CLI agents filtered by.filter(a => a.available), user/global provider mapping, and the error + Retry path vialoadProviders.
All test shards, coverage-gate, and detect-untested are green. The Fixes #24663 with deliberately partial scope is explained in the body (issue's keep-PRs-small guidance; Auto-QA re-detects the rest). Looks correct to me — maintainer approval is all that's left.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
hivecommons-hive
Bot
removed
role/trusted
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
✅ Post-Merge Verification: passedCommit: |
Adds unit tests for several components flagged without coverage. Fixes #24663 — remaining listed components left for follow-up PRs per the issue's keep-PRs-small guidance; Auto-QA re-detects them next run.
— hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 requested_by=@clubanderson