Repository navigation
🐛 fix: bump CI Go toolchain pins to 1.26.10 (GO-2026-6809) - #24528
Conversation
go.mod now requires go >= 1.26.10 (merged in #24524), but eight workflows still pin 1.26.9 explicitly, so 'go test ./...' on main fails with 'go.mod requires go >= 1.26.10 (running go 1.26.9; GOTOOLCHAIN=local)'. Bump every explicit pin to 1.26.10. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
✅ Deploy Preview for kubestellarconsole canceled.
|
|
👋 Hey @hivecommons-hive[bot] — thanks for opening this PR!
This is an automated message. |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 |
e01317f
ℹ️ Sentinel notice — informational; author is trusted (hive agent), merge is not blockedHive flagged this PR (author @hivecommons-hive[bot], head
Hive did not add the |
There was a problem hiding this comment.
Decision needed: @clubanderson should confirm this workflow-file pin bump (1.26.9 → 1.26.10, 9 occurrences in 8 workflows) may land — it edits .github/workflows/**, which is routed to an owner by policy even for mechanical version bumps.
Verified against main — this is correct and complete:
go.modon main already requiresgo 1.26.10(merged in #24524), so every workflow still pinning1.26.9fails underGOTOOLCHAIN=localexactly as the PR body's run 39569809377 shows. Main is broken for these jobs until the pins move.- I grepped the current tree: exactly 9 occurrences of
1.26.9remain under.github/, in precisely the 8 files this diff touches (api-contract.yml:20,auto-qa.yml:46,go-test.yml:69,nightly-test-suite.yml:21,nil-safety.yml:25,release.yml:188and:257,startup-smoke.yml:38,update-guard.yml:20). No stale pin is missed. - All other workflows use
go-version-file: go.mod(e.g.codeql.yml:40,cross-platform-build.yml:57), so they track the toolchain automatically and need no change. - The diff changes version strings only — no permissions, triggers, or steps are altered.
Looks correct to me and it unbreaks main CI. Routing to an owner only because it touches .github/workflows/**; the content itself is a mechanical, fully-covered pin bump. Note #24526 handles the separate go.mod/changelog side and does not overlap this diff.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
|
Needs a decision, not a merge:
Head: verdict requires_human @e01317f, 24/25 checks green, 1 pending, DCO yes, soak 0s of 30m0s. What to do: approve this head ( Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
Overlap: #24526 and #24528 bump the same Go 1.26.9 → 1.26.10 CI pins. #24528 covers the remaining gap (go.mod already on main via #24524) and carries the Closes lines; #24526 looks superseded. Maintainer to decide; consider cherry-picking the changelog fragment from #24526 into #24528. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 |
|
Another agent tried to open a PR from |
|
This PR also covers the remaining toolchain fix for #24523: the nightly dependency audit still selects Go 1.26.9 on main. Please cross-reference that regression when reviewing. If merge should close #24523, a maintainer must add Fixes #24523 to the PR body; otherwise retain it until the next nightly confirms the audit passes. I have not edited the PR body. — hive: backend=pi model=openai-codex/gpt-6.1-sol 🐝 Hive Agent: |
|
Another agent tried to open a PR from |
clubanderson
left a comment
There was a problem hiding this comment.
Go 1.26.10 is a published release and fixes GO-2026-6809; pins bumped consistently across 8 workflows. Intended — this also unbreaks main (#24527).
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 67fc8696d87fd68916cfb3e49642326af71cff48 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
Main-broken fix
go.modnow requiresgo >= 1.26.10(merged in #24524), but eight workflows still pin1.26.9explicitly. WithGOTOOLCHAIN=local,go test ./...on main fails:(run 39569809377, commit ae880ab)
This bumps every explicit
go-version/GO_VERSIONpin from1.26.9to1.26.10— all 9 occurrences across the 8 files listed in #24525:api-contract.yml, auto-qa.yml, go-test.yml, nightly-test-suite.yml, nil-safety.yml, release.yml (×2), startup-smoke.yml, update-guard.yml.
Closes #24527
Closes #24525 — this applies all 8 workflow pin replacements the issue parked as owner-only; the hive App token can in fact push
.github/workflows/**here.— hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88