Skip to content

aws: Prune LBC deployment#18222

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
rifelpet:lbc-prune
Apr 21, 2026
Merged

aws: Prune LBC deployment#18222
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
rifelpet:lbc-prune

Conversation

@rifelpet
Copy link
Copy Markdown
Member

@rifelpet rifelpet commented Apr 20, 2026

The Deployment's label selector is changing so we must prune it to prevent upgrade failures like in the manyaddons e2e tests

rifelpet added 2 commits April 20, 2026 15:11
@rifelpet
Prune LBC deployment
7a08ce5 
The Deployment's label selector is changing so we must prune it to prevent upgrade failures like in the manyaddons e2e tests
@rifelpet
./hack/update-expected.sh
9daad47
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 20, 2026
@k8s-ci-robot k8s-ci-robot requested a review from olemarkus April 20, 2026 20:12
@rifelpet
Copy link
Copy Markdown
Member Author

rifelpet commented Apr 20, 2026

/override pull-kops-e2e-aws-load-balancer-controller

@k8s-ci-robot k8s-ci-robot requested a review from zetaab April 20, 2026 20:12
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 20, 2026

@rifelpet: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • pull-kops-e2e-aws-load-balancer-controller

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • build-linux-amd64
  • build-linux-arm64
  • build-macos-amd64
  • build-windows-amd64
  • deploy/netlify
  • pull-kops-aws-upgrade-k134-ko134-to-k136-kolatest-many-addons
  • pull-kops-aws-upgrade-k135-ko135-to-k136-kolatest-many-addons
  • pull-kops-build
  • pull-kops-e2e-k8s-aws-amazonvpc
  • pull-kops-e2e-k8s-aws-calico
  • pull-kops-e2e-k8s-gce-cilium
  • pull-kops-e2e-k8s-gce-ipalias
  • pull-kops-test
  • pull-kops-verify-boilerplate
  • pull-kops-verify-generated
  • pull-kops-verify-gofmt
  • pull-kops-verify-golangci-lint
  • pull-kops-verify-gomod
  • pull-kops-verify-govet
  • pull-kops-verify-terraform
  • tests-e2e-scenarios-bare-metal
  • tests-e2e-scenarios-bare-metal-ipv6
  • verify-amd64
  • verify-arm64

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override pull-kops-e2e-aws-load-balancer-controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 20, 2026
@rifelpet
Copy link
Copy Markdown
Member Author

rifelpet commented Apr 20, 2026

test pull-kops-e2e-aws-load-balancer-controller

@rifelpet
Copy link
Copy Markdown
Member Author

rifelpet commented Apr 20, 2026

/test pull-kops-e2e-aws-load-balancer-controller

@rifelpet
Copy link
Copy Markdown
Member Author

rifelpet commented Apr 21, 2026

/cc @hakman

@k8s-ci-robot k8s-ci-robot requested a review from hakman April 21, 2026 00:31
@hakman hakman changed the title Prune LBC deployment aws: Prune LBC deployment Apr 21, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2026
@hakman
Copy link
Copy Markdown
Member

hakman commented Apr 21, 2026

/override pull-kops-e2e-aws-load-balancer-controller
/override pull-kops-e2e-k8s-gce-cilium

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 21, 2026

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-aws-load-balancer-controller, pull-kops-e2e-k8s-gce-cilium

Details

In response to this:

/override pull-kops-e2e-aws-load-balancer-controller
/override pull-kops-e2e-k8s-gce-cilium

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit b7efdd5 into kubernetes:master Apr 21, 2026
30 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman hakman approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.36

Development

Successfully merging this pull request may close these issues.

3 participants

@rifelpet @k8s-ci-robot @hakman