Skip to content

addons: render addons as tasks#18215

Open
hakman wants to merge 1 commit intokubernetes:masterfrom
hakman:addons-tasks
Open

addons: render addons as tasks#18215
hakman wants to merge 1 commit intokubernetes:masterfrom
hakman:addons-tasks

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Apr 18, 2026

Defer addon manifest rendering and bootstrap-channel assembly into AddonManifest and BootstrapChannel fi-tasks so addon templates can reference the finalized task graph.

/cc @justinsb @rifelpet
/assign @justinsb

/hold for feedback

@hakman
addons: render addons as tasks
9438c44 
Defer addon manifest rendering and bootstrap-channel assembly into
AddonManifest and BootstrapChannel fi-tasks so addon templates can
reference the finalized task graph.

Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2026
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 18, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hakman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 18, 2026

Remove the noise, will fix separately.
/override pull-kops-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons
/override pull-kops-aws-upgrade-k134-ko134-to-kstable-kolatest-many-addons
/override pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 18, 2026

@hakman: Overrode contexts on behalf of hakman: pull-kops-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons, pull-kops-aws-upgrade-k134-ko134-to-kstable-kolatest-many-addons, pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons

Details

In response to this:

Remove the noise, will fix separately.
/override pull-kops-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons
/override pull-kops-aws-upgrade-k134-ko134-to-kstable-kolatest-many-addons
/override pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 18, 2026

/test pull-kops-e2e-k8s-aws-calico

@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Apr 18, 2026

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@justinsb justinsb

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hakman @k8s-ci-robot @k8s-triage-robot @justinsb