Support NLBSecurityGroupMode for AWS Cloud Controller Manager#18211
Support NLBSecurityGroupMode for AWS Cloud Controller Manager#18211mfbonfigli wants to merge 2 commits intokubernetes:masterfrom
Conversation
Adds nlbSecurityGroupMode field to cluster spec and elasticloadbalancing:SetSecurityGroups IAM permission for AWS Cloud Controller Manager to support managed security groups for AWS Network Load Balancers.
|
Welcome @mfbonfigli! |
|
Hi @mfbonfigli. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/retest |
What this PR does / why we need it:
This PR adds support for the
NLBSecurityGroupModecloud configuration setting and theSetSecurityGroupsIAM permission for AWS Cloud Controller Manager.When
nlbSecurityGroupMode: Managedis set in the cluster spec, kops writesNLBSecurityGroupMode = Managedto the cloud config file, enabling CCM to create and manage dedicated security groups for each Network Load Balancer instead of provisioning NLBs without security groups.The
SetSecurityGroupsIAM permission allows CCM to attach/detach security groups from cluster-owned NLBs, bringing CCM to parity with the AWS Load Balancer Controller which already has this permission and enabling the BYO Security Groups feature for NLBs in AWS CCM.Please refer to issue #18210 for more details on why this change is needed.
Changes:
NLBSecurityGroupModetoAWSSpecandCloudConfigurationwith bidirectional conversion"Managed"value (case-sensitive) or omitted/nil.elasticloadbalancing:SetSecurityGroupsto CCM role inclusterTaggedActionblock.NLBSecurityGroupMode = Managedto/etc/kubernetes/cloud.configon master nodesWhich issue(s) this PR fixes:
Fixes #18210
Special notes for your reviewer:
Large number of changed files: many auto-generated IAM policy golden test files were updated via
hack/update-expected.shto include the newSetSecurityGroupspermission.Related upstream work: