Conversation
|
This issue is currently awaiting triage. If the repository mantainers determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LogicalShark The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign hdp617 |
eb87994 to
11f7455
Compare
|
|
For the quickstart, I was approaching it from a customer's perspective: 'What's the fastest way to get a self-managed k8s cluster?' The current approach is great for local dev changes to the component, but I'm more interested in targeting the customer experience here. How about separating this into 2?
|
03427c3 to
1cc9372
Compare
2ed2381 to
4102b67
Compare
b9ed23d to
644854b
Compare
zhang-xuebin
left a comment
There was a problem hiding this comment.
Nice work, thanks @LogicalShark !
1c9e926 to
67dc025
Compare
|
fantastic 🥇 |
| --tags=k8s-worker | ||
| ``` | ||
|
|
||
| ## Step 2: Access and Configure Nodes (Master and Worker) |
There was a problem hiding this comment.
IIUC, steps 2-6 are essentially https://github.com/kelseyhightower/kubernetes-the-hard-way. How about adding a reference to that doc instead?
cb97a06 to
69ebc43
Compare
|
Hold in case you want to make minor changes. Feel free to cancel it once you're ready to merge. /lgtm |
|
@LogicalShark: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes #1019