feat(chart): add PodDisruptionBudget for high availability - #411
Conversation
✅ Deploy Preview for node-readiness-controller ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @vishnukothakapu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This adds an optional PodDisruptionBudget to the Helm chart, which is highly recommended for critical controllers to prevent eviction of all replicas during node drains or upgrades.
bdeb3a0 to
40d80a3
Compare
Ayush4958
left a comment
There was a problem hiding this comment.
It's seems good to me
@ajaysundark can review for further review
|
/test pull-node-readiness-controller-junit-report-canary |
|
/ok-to-test |
|
same as #437 (comment). I want to better understand what level of preconfiguration will be handled at the helm chart. Could you help us with some research? Thanks! |
|
@Ayush4958 had some references at #437. It's good to add to our charts. Thanks @vishnukothakapu . /lgtm |
|
the helm tests are failing and need your second look /assign @vishnukothakapu |
9b4ade0 to
9c814e6
Compare
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ajaysundark, Ayush4958, vishnukothakapu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This adds an optional
PodDisruptionBudgetto the Helm chart (charts/node-readiness-controller). Since the controller manages node taints, it's critical infrastructure. Adding a PDB allows users running multiple replicas to ensure the controller remains highly available during node drains, cluster upgrades, or other evictions.The PDB is disabled by default (
podDisruptionBudget.enabled: false). Existing installations that do not explicitly opt-in to this feature will see no changes in rendered manifests.Related Issue
Fixes #410
Type of Change
/kind feature
Testing
helm-unittestcoverage incharts/node-readiness-controller/tests/pdb_test.yamlto ensure it only renders when enabled, respectsminAvailable/maxUnavailable, and correctly inherits the selector labels.Checklist
make testpassesmake lintpassesDoes this PR introduce a user-facing change?