Skip to content

fix: stop the chart suggesting an empty nodeSelector #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubernetes-prow merged 2 commits into from
Aug 13, 2026
Merged

fix: stop the chart suggesting an empty nodeSelector #404

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e01278e
fix: stop the chart suggesting an empty nodeSelector
tejassinghbhati Aug 13, 2026
fe723bb
cleanup: apply reviewer wording for the nodeSelector message
tejassinghbhati Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/nrr-controller/templates/nodereadinessrules.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{{- range $rule := .Values.nodeReadinessRules }}
{{- $spec := omit $rule "name" }}
{{- if or (not (hasKey $spec "nodeSelector")) (kindIs "invalid" $spec.nodeSelector) }}
{{- fail (printf "nodeReadinessRules[%s]: spec.nodeSelector is required and immutable. Set it explicitly; use 'nodeSelector: {}' only if the rule is intended to match ALL nodes." ($rule.name | default "?")) }}
{{- fail (printf "nodeReadinessRules[%s]: spec.nodeSelector is required and immutable. An empty selector to match every node in the cluster is rejected by the validating webhook to avoid cluster wide misconfiguration risks." ($rule.name | default "?")) }}
{{- end }}
---
apiVersion: readiness.node.x-k8s.io/v1alpha1
Expand Down