fix: harden testing/ and developing scripts - #1285
Open
andyatmiami wants to merge 2 commits into
Open
Conversation
The sanity-check script validates that all components are deployed and responsive, but never validated the sample WorkspaceKind manifests. This meant broken YAML or CRD schema regressions in sample files went undetected by CI. Add a new section that runs server-side dry-run validation against all sample WorkspaceKind YAMLs, catching parse errors, schema violations, and webhook rejections without creating any resources. Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
The pod readiness wait could fail with "no resources found" if the Prometheus operator hadn't reconciled and created the pods yet. Add an explicit wait for the Prometheus CR to reach Available before checking pod readiness, giving the operator time to spawn the pods. Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
christian-heusel
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ NO GH ISSUE
Ran into a couple minor annoyances during PR reviews that would be nice to fix.
(1) When enabling PROMETHEUS in
tilt- I got an error (likely a race condition) thatkubectl wait ... podsfailed because the pods hadn't been created yet... waiting on Prometheus CR to beAvailableseems the obvious hardening choice here.(2) In reviewing #1263 - i had a typo in the PR "suggestion" I offered.. which lead to an extra whitespace and invalid YAML for our
codeserverWSK that got carried into the author's fixes... and to make matters worse - all our GHA checks passed... Added a small/idempotent/trivial addition tosanity-check.shthat will reasonably catch regressions in our sample files - which seems aligned with the purpose ofsanity-check.sh