Repository navigation
Conversation
The MCP server's RERANKER_URL points at reranker-service in ml-infra, which was only defined in Terraform and never deployed, so reranking was silently skipped. Signed-off-by: Rohit Kumar <rr7433446@gmail.com>
ClickHouse rejects DELETE on a replicated table when the condition calls a non-deterministic function, so every run since the tables were replicated failed with BAD_ARGUMENTS on now(). Compute the cutoff in the shell instead. Signed-off-by: Rohit Kumar <rr7433446@gmail.com>
…renews httpsRedirect sets require_tls on the port 80 virtual host, so Envoy redirects before routing and cert-manager's HTTP-01 solver route is never reached; on 443 nothing serves the challenge path. Drop the redirect and match the real routes on port 443 only: plain HTTP now serves the challenge and nothing else. Signed-off-by: Rohit Kumar <rr7433446@gmail.com>
…query retrieval Ingest - Register the docs, issues and code pipelines as Kubeflow Pipelines recurring runs from an Argo CD PostSync Job (ingest_schedule.py, chart value ingest.*). - Build and push the ingest image in CI; the docs pipeline needs it and it was never published. - Docs pipeline: download by tree listing, fail on unreadable files, optional doc_type and exclude_paths, prune pages removed upstream (refused above 20%). - Index kubeflow/community-distribution Markdown in kubeflow_docs with doc_type distribution; drop badge-only chunks. - Issues: ten repositories, most recently updated first, optional time window. - Code: kubeflow/community-distribution without CustomResourceDefinitions. Retrieval - Latest/new-release questions also search non-release pages. - Fetch more candidates when a reranker is configured. - Docs prompt: product questions that do not name Kubeflow still need a search. Signed-off-by: Rohit Kumar <rr7433446@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
|
/eval |
|
Eval of |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two questions from a maintainer got "could not find" answers:
kubeflow/community-distribution(README and Helm chart READMEs).Looking at the cluster showed the wider problem: nothing ingests on a schedule (docs last indexed 30 Aug, issues and code 17 Aug), and the image the docs pipeline runs in (
ghcr.io/kubeflow/docs-rag-ingest) was never published.What changes
Ingest
The docs, issues and code pipelines become Kubeflow Pipelines recurring runs, registered by an Argo CD PostSync Job (
ingest_schedule.py, chart valuesingest.*, on in production only).docs-websitekubeflow/websitedocsdocs-distributionkubeflow/community-distributionMarkdown,doc_type: distribution, same collectionissuescodeCI builds and pushes the ingest image per commit;
promote.shchecks it exists.The docs pipeline fails on an incomplete download and removes pages deleted upstream. It refuses to remove more than 20% of a source.
Badge-only chunks are dropped (they were the top hits for the Helm question).
Retrieval
top_k.Platform fixes found on the way
rerankerArgo CD app:RERANKER_URLpointed at a service that was never deployed.DELETE ... now()is rejected on replicated ClickHouse tables; the job has failed weekly since.httpsRedirecton port 80 blocks cert-manager's HTTP-01 challenge, sokagent-ui-certhas not renewed since 28 Oct and expires 27 Nov. Port 80 now serves only the challenge; the routes match port 443.Tested
pytest: 190 passed (30 new intests/test_rag_quality_ingest.py); ruff clean; all three pipelines compile; Helm lint and render with ingest on and off, TLS on and off.kubeflow/community-distribution: 96 files, 1006 chunks.Not tested yet
/evalwith the prompt change.After merge
docs-rag-ingestpackage on GHCR must be public (or pullable from thekubeflownamespace).--set updated_within_hours=0) and deletecode_ragrows withrepo_name == "kubeflow/manifests".deploy/envs/prod/ingress/have the same redirect; follow-up once this fix is confirmed on the chatbot host.