Repository navigation
fix(pipelines): don't duplicate the first node's decorator in the module header - #285
Open
sayaksatpathi wants to merge 4 commits into
Open
sayaksatpathi wants to merge 4 commits into
sayaksatpathi wants to merge 4 commits into
Conversation
…ule header parse_python_ast set the module_header boundary at the first node's def/class line (nodes[0].lineno). When that node is decorated, its own chunk starts at the decorator line, so the decorator was captured in both the header chunk and the function chunk -- common for Kubeflow code using @dsl.component / @dsl.pipeline. Use the decorator line as the header boundary when the first node has decorators. Adds a regression test. Signed-off-by: Sayak Satpathi <sayaksatpathi12@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
|
Thanks @sayaksatpathi , |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #284.
parse_python_astcomputed themodule_headerboundary from the first node'sdef/classline (nodes[0].lineno). When that node is decorated, its own chunk starts at the decorator line, so the decorator line(s) were captured in both the header chunk and the function chunk — common for Kubeflow code using@dsl.component/@dsl.pipeline.Fix
Use
nodes[0].decorator_list[0].linenoas the header boundary when the first node is decorated. The decorator now belongs to the function chunk only.Tests
Added
test_decorated_first_node_not_duplicated_in_headertotests/test_code_utils.py. It fails on the current code (the header chunk ends with@dsl.component) and passes with this change. The existingparse_python_asttests continue to pass andruff checkis clean.