Preserve formatting for complete SGR parameter syntax - #144
Open
OskarEichler wants to merge 1 commit into
Open
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve requested formatting when a string contains an ESC byte outside its initial SGR sequence, and recognize both semicolon and colon SGR parameter forms while wrapping or removing formatting.
Reproduction
On current master, wrapping
plain \e[34mblue\e[0mwith red returns the string unchanged because the optimized ESC path only inserts after a non-empty initial legacy SGR match.Rainbow.uncolor("\e[38:2::1:2:3mtext\e[m")also leaves the colon-form color sequence.The updated initial match is anchored with
\A, accepts empty parameters such as\e[m, and accepts the colon subparameter syntax documented by xterm's control-sequence reference. Non-SGR control sequences remain untouched. The existing no-ESC fast path is unchanged.Verification
Compatibility
No API break. Output changes only for SGR inputs that were previously not wrapped or fully removed as intended.