Repository navigation
Fix/arm bench - #324
Open
davidmiheev wants to merge 2 commits into
Open
Fix/arm bench#324davidmiheev wants to merge 2 commits into
davidmiheev wants to merge 2 commits into
Conversation
bench.h included <x86intrin.h> unconditionally for an unused rdtsc(), which breaks the ConvexHull stress test on ARM (e.g. Raspberry Pi). Only define rdtsc() on x86; tick() and timeit are unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011rLUNgQTuqGH79WJWupFZK
The expectSuccess=false tests loop until modmul gives a wrong answer, which relies on x87's 64-bit mantissa. With a wider long double (binary128 on aarch64) modmul stays correct up to ~2^63, so they never terminate. Only run them when LDBL_MANT_DIG == 64. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011rLUNgQTuqGH79WJWupFZK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.